Changed find_first_model to cope with Mongoid 3.0.0 #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Many thanks! |
bbenezech
added a commit
to bbenezech/pickle
that referenced
this pull request
Oct 15, 2012
Changed find_first_model to cope with Mongoid 3.0.0
|
Agreed. |
|
Strike that, reverse it. #47 was for ActiveRecord, this is for Mongoid. |
|
Aaaah! Sorry. The code is the exact same, but it's in different files. I didn't notice that! Do we need to update https://github.com/julescopeland/pickle/blob/master/lib/pickle/adapters/mongoid.rb#L35 too? Seems like it could be: klass.all(conditions) |
|
Already on it. Fixed in a backwards-compatible way. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Klass.first(conditions) no longer works in Mongoid 3 (it breaks with an ArgumentError).
Updated the method to stop it raising errors. (It should still work in previous versions too).